Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coverage check #225

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

wulfraem
Copy link
Contributor

Description of change

This PR updates the code instrument-coverage flag to be set as a stable option, as this option has moved from unstable to stable.

Updated clippy found unexpected cfgs has_i128 and has_u128. As those are set in the build.rs, linting rule has been configured in Cargo.toml to allow the known two cfgs.

It also adds a changelog entry for the previous (#223).

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix
  • Chore

How the change has been tested

Code coverage command from CI ran successfully in local tests.

Change checklist

Add an x to the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@semenov-vladyslav semenov-vladyslav merged commit d8fb4ed into iotaledger:dev Aug 14, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants